Skip to content

Conversation

@forestyoo
Copy link
Contributor

@forestyoo forestyoo commented Jun 6, 2025

Description

This PR fixes the issue where HTML tags in the Message are removed when clicking the copy button in HistoryView.
Reason: There was existing code logic that stripped HTML tags from the message during the copy operation, leading to incomplete copied content.
Solution: Removed the aforementioned code logic.

Test Procedure

  1. Send the message explain this html code <div>Test</div> to Roo to initiate a task.
  2. Click the "New Task" button.
  3. Click the "Copy" button in the top right corner of the task you just created.
  4. Paste it into the input box and observe that the message has changed to explain this html code Test.

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

record.mov

Documentation Updates

Additional Notes

Get in Touch


Important

Fixes HTML tag removal issue in CopyButton by directly copying itemTask string.

  • Behavior:
    • Fixes issue in CopyButton component where HTML tags were removed during copy operation.
    • Directly copies itemTask string without stripping HTML tags.
  • Code Changes:
    • Removes creation of temporary div and text extraction logic in CopyButton.tsx.

This description was created by Ellipsis for 8db2409. You can customize this summary. It will automatically update as commits are pushed.

@forestyoo forestyoo requested review from cte, jr and mrubens as code owners June 6, 2025 15:45
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 6, 2025
@forestyoo forestyoo closed this Jun 6, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 6, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 6, 2025
@forestyoo forestyoo deleted the copybutton branch June 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant